Font Icon sets aren't supported

[bryceschober]

Description

It appears that the :icons: font attribute does use font-awesome icons in the previewer, the icon set attributes are not.

System Information

VS Code: Version: 1.37.1 Commit: f06011ac164ae4dc8e753a3fe7f9549844d15e35 Date: 2019-08-15T16:17:25.463Z Electron: 4.2.7 Chrome: 69.0.3497.128 Node.js: 10.11.0 V8: 6.9.427.31-electron.0 OS: Linux x64 4.4.0-148-generic

AsciiDoc plugin 2.7.6

To Reproduce

:icons: font
:icon-set: far

* [ ] This list item gets an open "regular"-style square automatically.

icon:square[] This should result in the same, with the above `icon-set` document attribute setting

icon:square[set=far] This should as well, even with the `icon-set` document attribute setting commented out

You will see a filled square for the second two, in both the previewer and the export to PDF result. On the other hand, if use an installed asciidoctor-pdf directly, you get open squares.

[danyill]

You can presently use:

Name: AsciiDoc Icon Snippets Id: satakeryota.asciidoc-icon-snippets Description: AsciiDoc Icon: Snippets and intellisense. Be careful ,please write ':icons: font'. Then do work well. Version: 0.0.7 Publisher: SatakeRyota VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=SatakeRyota.asciidoc-icon-snippets

Ideally we'd integrate the code from that extension into this one.

On Tue, Aug 20, 2019 at 12:40 PM Bryce Schober notifications@github.com wrote:

Description

It appears that the :icons: font attribute does use font-awesome icons in the previewer, the icon set attributes are not. System Information

VS Code: Version: 1.37.1 Commit: f06011ac164ae4dc8e753a3fe7f9549844d15e35 Date: 2019-08-15T16:17:25.463Z Electron: 4.2.7 Chrome: 69.0.3497.128 Node.js: 10.11.0 V8: 6.9.427.31-electron.0 OS: Linux x64 4.4.0-148-generic

AsciiDoc plugin 2.7.6 To Reproduce

:icons: font:icon-set: far

• [ ] This list item gets an open "regular"-style square automatically.icon:square[] This should result in the same, with the above icon-set document attribute setting

icon:square[set=far] This should as well, even with the icon-set document attribute setting commented out

You will see a filled square for the second two, in both the previewer and the export to PDF result. On the other hand, if use an installed asciidoctor-pdf directly, you get open squares.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/asciidoctor/asciidoctor-vscode/issues/218?email_source=notifications&email_token=AAFEXX5RNUR5TCPQVN7H4VDQFM4RXA5CNFSM4INJ5YK2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HGDXWWA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFEXX4RCEFAB4XOZDGKK7DQFM4RXANCNFSM4INJ5YKQ .

--

-- Private or confidential message? Public Key available here https://pgp.mit.edu/pks/lookup?search=dan.mulholland%40gmail.com&op=index :

[bryceschober]

I'm not talking about autocomplete, which seems to be all that extension is about. I'm talking about the preview rendering.

[danyill]

That extension does the preview rendering.

[image: image.png]

On Tue, Aug 20, 2019 at 2:42 PM Bryce Schober notifications@github.com wrote:

I'm not talking about autocomplete, which seems to be all that extension is about. I'm talking about the preview rendering.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/asciidoctor/asciidoctor-vscode/issues/218?email_source=notifications&email_token=AAFEXX2VDARPKL6O6DJOSTLQFNKYHA5CNFSM4INJ5YK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4U335Q#issuecomment-522829302, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFEXX2WPXQ4HVTN2F376H3QFNKYHANCNFSM4INJ5YKQ .

--

-- Private or confidential message? Public Key available here https://pgp.mit.edu/pks/lookup?search=dan.mulholland%40gmail.com&op=index :

[ggrossetie]

This is what I get:

@bryceschober Could you please take a screenshot of what you get and what you would expect?

[bryceschober]

I get very much the same output with asciidoctor-vscode. As previously mentioned, I get a different output from a full asciidoctor-pdf installation, see attached: test.pdf

In VS Code, all three checkboxes are rendered as the solid styling, not the requested regular style (see :icon-set: far and icon:square[set=far]). The asciidoctor-pdf produces output that looks like the expected regular style with outlining. I now see that I left off that detail in the original post, sorry.

Here's the font-awesome search for the square icon that shows its variants.

[ggrossetie]

Thanks for clarifying. The icon set feature is not supported on the built-in HTML 5 converter, see: https://github.com/asciidoctor/asciidoctor/issues/3694

Once this feature is available upstream, it will be available in the VS Code extension. In theory, we could provide our own custom HTML 5 converter but that would lead to a higher maintenance effort that's why we've decided to use the built-in HTML 5 converter.