asciidoctor / asciidoctor-vscode

AsciiDoc support for Visual Studio Code using Asciidoctor
Other
326 stars 98 forks source link

Support view attribute for Structurizr docs rendered with Kroki #735

Closed timw closed 1 year ago

timw commented 1 year ago

Using asciidoctor-vscode (both 2.9.8 and 3.0.6) to render Asciidoc with Structurizr diagrams containing multiple views, only the last view defined in the Structurizr diagram is rendered in the preview.

With a large Structurizr workspace (which might commonly be managed in an external file to the Asciidoc) there will be many views, so these aren't rendered correctly in the preview.

Asciidoctor-diagram defines the view attribute 1 for specifying the view to render. Kroki defines the view-key option 2 to specify the view to render for Structurizr inputs.

It would be great if the preview renderer could map the standard view attribute on the diagram block to the Kroki view-key option so these diagrams are rendered correctly in preview.

ggrossetie commented 1 year ago

That's a good point but I think we should handle that in Asciidoctor Kroki: https://github.com/ggrossetie/asciidoctor-kroki If there are some differences between Asciidoctor Diagram and Asciidoctor Kroki, we can certainly map view to view-key.

So please, open a new issue at: https://github.com/ggrossetie/asciidoctor-kroki/issues

timw commented 1 year ago

Raised https://github.com/ggrossetie/asciidoctor-kroki/issues/418 to address in asciidoctor-kroki