asciidoctor / asciidoctor-vscode

AsciiDoc support for Visual Studio Code using Asciidoctor
Other
326 stars 98 forks source link

Plantuml diagrams don't show in the preview in 3.1.0 #746

Closed KindaAlhammadehGraniten closed 1 year ago

KindaAlhammadehGraniten commented 1 year ago

Hi! Yesterday after updating the AsciiDoc extension in Visual Studio all my plantuml diagrams didn't appear correctly as before.

This is my code:

[plantuml]
----
state Init

State CartonHandling{
    state "Idle" as CHI
    state "TransportIn" as TRI
    state "TransportOut" as TRO
    state "TamperEvidentApplication" as APL
    state "LabelChecking" as LCH

    [*] --> CHI 
    CHI --> TRI : Carton in place
    TRI --> APL : Carton ready for labelling
    APL --> LCH : Label applied
    LCH --> TRO : Vision results acquired
    TRO --> CHI : Carton in TMX
}

[*] --> Init
Init --> CartonHandling
----

It appeared so before:

MicrosoftTeams-image (2)

And now it is so:

Screenshot 2023-07-12 094622

Please how to solve this problem.

ggrossetie commented 1 year ago

Is asciidoc.extensions.enableKroki enabled in your settings?

KindaAlhammadehGraniten commented 1 year ago

I did not enable it before updating(I,m not sure if it is enabled by default), but now after enabling it, the plantuml diagrams appear correctly. Thanks a lot.

ggrossetie commented 1 year ago

I don't recall maybe it was enabled by default but since we are sending data to https://kroki.io some users requested to disable it by default.

ggrossetie commented 1 year ago

I've added a note in the Breaking changes section: https://github.com/asciidoctor/asciidoctor-vscode/releases/tag/v3.1.0