search

asciidoctor / asciidoctor-vscode

AsciiDoc support for Visual Studio Code using Asciidoctor
Other
323 stars 97 forks source link

Update asciidoctor-kroki #783

Closed sixtysecrun closed 10 months ago

sixtysecrun commented 10 months ago

The currently used version of asciidoctor-kroki does not allow to pass diagram options to kroki server as described here: https://github.com/ggrossetie/asciidoctor-kroki/issues/334

That is particularity useful when working with structurizr diagrams that define more than one view and you want to select one of them:

diagram.dsl

``` workspace { model { user = person "User" softwareSystem = softwareSystem "Software System" { webapp = container "Web Application" { user -> this "Uses!!!" } database = container "Database" { webapp -> this "Reads from and writes to" } } } views { systemContext softwareSystem "diag1" { include * autolayout lr } container softwareSystem "diag2" { include * autolayout lr } theme default } } ``` 

[structurizr,diag1,svg,view-key=diag1]
----
include::diagram.dsl[]
----
structurizr::diagram.dsl[svg,view-key=diag2]

The currently used version does not pass view-key to kroki server and therefore the rendered diagram is randomly chosen from one of the defined views. The updated version has solved this issue.

sixtysecrun commented 10 months ago

@ggrossetie Are you able (and willing 😄 ) to release a new version with the asciidoctor-kroki update?