asciidoctor / asciidoctor-vscode

AsciiDoc support for Visual Studio Code using Asciidoctor
Other
341 stars 97 forks source link

Preview stops working if reference to bibliography entry exists in 3.2.1 #857

Closed TuxTom closed 8 months ago

TuxTom commented 8 months ago

Minimal test document to reproduce:

= Test

See <<ref>>

[bibliography] == Bibliography

  • [[[ref]]] Reference

System Information: Version: 1.87.2 (user setup) Commit: 863d2581ecda6849923a2118d93a088b0745d9d6 Date: 2024-03-08T15:20:17.278Z Electron: 27.3.2 ElectronBuildId: 26836302 Chromium: 118.0.5993.159 Node.js: 18.17.1 V8: 11.8.172.18-electron.0 OS: Windows_NT x64 10.0.19045

Extension version: v3.2.1

ggrossetie commented 8 months ago

@ViToni It seems that we need to make sure that getTitle is available on refNode. Could you please take a look?

ViToni commented 8 months ago

@ggrossetie I'll look into it. @TuxTom Thanks for the reproducer.

ViToni commented 8 months ago

@ggrossetie Seems the problem is even worse as all refs to anchors fail, so no bibliography needed to make it fail. This is a minimal example failing for me:

= Test

See <<inline_anchor>>

[[inline_anchor]]Some text

PR #859 should fix the underlying issue.

ViToni commented 8 months ago

@TuxTom May you give the branch from the PR a try. @ggrossetie Could you please review the PR.

TuxTom commented 8 months ago

@ViToni Tried the branch, this indeed fixes the issue for me.

Thanks for the swift response!