search

asciidoctor / asciidoctor-vscode

AsciiDoc support for Visual Studio Code using Asciidoctor
Other
340 stars 97 forks source link

Right-click causes incorrect multi-select behavior #885

Open dkontyko opened 5 months ago

dkontyko commented 5 months ago

Type: Bug

When I Ctrl+left-click to select 2 files, then right-click one of the files to show the context menu, the last file I selected is un-selected, leaving only the first file to be selected. This prevents me from using functionality like Compare Selected. VS Code Extension Bisect identified this extension as the cause.

Steps to Repro:

  1. Left-click any file in Explorer to select it.
  2. Press and hold Ctrl, then left-click a 2nd file in Explorer to select it.
  3. Release Ctrl, then right-click either file.

Expected: The context menu displays while both files remain selected.

Actual: The context menu displays, but the 2nd file is un-selected.

Extension version: 3.2.3 VS Code version: Code - Insiders 1.91.0-insider (fec18ef7d6793521c4683e67e569579ea970cc6d, 2024-06-10T05:48:36.787Z) OS version: Windows_NT x64 10.0.22635 Modes: Connection to 'wsl+rocky9' could not be established

System Info |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (8 x 3600)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|63.84GB (48.36GB free)| |Process Argv|--crash-reporter-id 199cdb7e-8675-426c-85e0-8f5b02bbf3cd| |Screen Reader|no| |VM|0%| Connection to 'wsl+rocky9' could not be established
A/B Experiments ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscod805cf:30301675 vsaa593:30376534 py29gd2263:31024238 c4g48928:30535728 962ge761:30841072 pythongtdpath:30726887 welcomedialog:30812478 pythonidxpt:30768918 pythonnoceb:30776497 asynctok:30898717 dsvsc013:30777762 dsvsc014:30777825 dsvsc015:30821418 pythontestfixt:30866404 pythonregdiag2:30926734 pythonmypyd1:30859725 h48ei257:31000450 pythontbext0:30879054 accentitlementst:30870582 dsvsc016:30879898 dsvsc017:30880771 dsvsc018:30880772 cppperfnew:30980852 pythonait:30973460 jchc7451:31067543 showvideot:31016890 chatpanelt:31014475 f3je6385:31013174 a69g1124:31018687 dvdeprecation:31040973 pythonprt:31036556 dwnewjupytercf:31046870 nb_pkg_only:31057982 26j00206:31048877 refactorc:31067742 ```
ggrossetie commented 5 months ago

What is the connection with the AsciiDoc extension?

dkontyko commented 5 months ago

What is the connection with the AsciiDoc extension?

The issue only occurs when the AsciiDoc extension is enabled in a Windows Subsystem for Linux (WSL) environment. I disabled all other extensions (except for WSL). When I disable the AsciiDoc extension, the problem does not occur. However, when I re-enable the AsciiDoc extension within the WSL environment, the issue reliably reoccurs.

I tested this on Windows outside of WSL, and it does not occur for me, so it seems to be specific to running the extension in WSL.

ggrossetie commented 5 months ago

That's really specific, I will try to reproduce this issue. Any error in the developer tools? Could you take a screencast of that behavior (and a screencast of the behavior when the Asciidoctor extensions is disabled) ?