asciidoctor / asciidoctor-vscode

AsciiDoc support for Visual Studio Code using Asciidoctor
Other
341 stars 97 forks source link

Use ripgrep instead of vscode findFiles #910

Closed ggrossetie closed 1 month ago

ggrossetie commented 1 month ago

Based on https://github.com/asciidoctor/asciidoctor-vscode/pull/909

ggrossetie commented 1 month ago

@alaindresse Could you please give it a try? I removed the cache because we don't have an invalidation mechanism in case a file is removed

ggrossetie commented 1 month ago

On Windows it does not work:

Error: spawn d:\a\asciidoctor-vscode\asciidoctor-vscode\node_modules\@vscode\ripgrep\bin\rg.exe ENOENT
ggrossetie commented 1 month ago

Might be a drive letter issue since rg.exe is correctly downloaded:

D:\a\asciidoctor-vscode\asciidoctor-vscode\node_modules\@vscode\ripgrep\bin
Error: spawn d:\a\asciidoctor-vscode\asciidoctor-vscode\node_modules\@vscode\ripgrep\bin\rg.exe ENOENT

Or a backslash/frontslash issue.

alaindresse commented 1 month ago

@alaindresse Could you please give it a try? I removed the cache because we don't have an invalidation mechanism in case a file is removed

Just gave it a try. Seems to work fine. Thank you so much !