search

asciidoctor / asciidoctor.org

:globe_with_meridians: Asciidoctor project site. Composed in AsciiDoc. Baked with Awestruct.
https://asciidoctor.org
Other
322 stars 807 forks source link

Update extensions.adoc #1032

Closed sanyasandor closed 7 months ago

sanyasandor commented 7 months ago

extended with HTML Image Map block processor

mojavelinux commented 7 months ago

Can you provide a syntax example in the README of the project that shows how this extension is used in an AsciiDoc document?

sanyasandor commented 7 months ago

README is now updated. Also attached a generated html next to the example.adoc

mojavelinux commented 7 months ago

Thanks. Though when I said README, I was actually talking about the description on this page: https://launchpad.net/imagemap-block-processor I missed that there was a README in the repository.

Also attached a generated html next to the example.adoc

That seems unnecessary. Generally you shouldn't commit generated files.

When I looked at the README, I noticed this:

==  ImageMap example
:doctype: html

That's not valid. The doctitle should only have single =, and html is not a valid doctype. It should be:

=  ImageMap example

As for merging this, I would prefer to add it to this list here: https://github.com/asciidoctor/asciidoctor-extensions-lab#other-extensions There are things about this extension that I consider to be unorthodox and I don't want to promote it (at least not yet) as a community extension. The lab is really where this reference belongs for now.

sanyasandor commented 7 months ago

Thanks for the hint. I updated that introduction page on Launchpad as well and removed the :doctype: from all examples, also the generated file is gone. My goal was to share this, was not sure about the proper place. This one seemed practical with a simple link to the repository.

How shall I proceed with the extensions-lab ? Shall I make a pull request there initially, and whenever an update is coming ?

Dan Allen @.***> ezt írta (időpont: 2023. dec. 7., Cs, 20:56):

Thanks. Though when I said README, I was actually talking about the description on this page: https://launchpad.net/imagemap-block-processor I missed that there was a README in the repository.

Also attached a generated html next to the example.adoc

That seems unnecessary. Generally you shouldn't commit generated files.

When I looked at the README, I noticed this:

== ImageMap example :doctype: html

That's not valid. The doctitle should only have single =, and html is not a valid doctype. It should be:

= ImageMap example

As for merging this, I would prefer to add it to this list here: https://github.com/asciidoctor/asciidoctor-extensions-lab#other-extensions There are things about this extension that I consider to be unorthodox and I don't want to promote it (at least not yet) as a community extension. The lab is really where this reference belongs for now.

— Reply to this email directly, view it on GitHub https://github.com/asciidoctor/asciidoctor.org/pull/1032#issuecomment-1846016291, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEJI6JLB2TMOPBHEV4E2NILYIINQNAVCNFSM6AAAAABAJ5A2NGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBWGAYTMMRZGE . You are receiving this because you authored the thread.Message ID: @.***>

mojavelinux commented 7 months ago

I can take care of adding it there. No need to worry. You've provided all the information I need. Thanks!

sanyasandor commented 7 months ago

Great ! thanks ! :-)

Dan Allen @.***> ezt írta (időpont: 2023. dec. 7., Cs, 21:42):

I can take care of adding it there. No need to worry. You've provided all the information I need. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/asciidoctor/asciidoctor.org/pull/1032#issuecomment-1846082575, or unsubscribe https://github.com/notifications/unsubscribe-auth/BEJI6JLBM2IG35A3ZQXEP3TYIIS2FAVCNFSM6AAAAABAJ5A2NGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBWGA4DENJXGU . You are receiving this because you authored the thread.Message ID: @.***>