search

asciidoctor / asciidoctor.org

:globe_with_meridians: Asciidoctor project site. Composed in AsciiDoc. Baked with Awestruct.
https://asciidoctor.org
Other
322 stars 805 forks source link

Image macro documentation for svg images added #810

Closed danyill closed 5 years ago

danyill commented 5 years ago

Close #476

mojavelinux commented 5 years ago

Oh, this is fantastic. I've been meaning to do this forever. Thanks for taking the lead on this. Are you good to merge?

After I merge, I'm going to follow up and add a reference to https://svgontheweb.com/. That's a really nice book for learning how to use SVG effectively on the web, which is good prerequisite knowledge for using SVG in AsciiDoc.

danyill commented 5 years ago

Yes, I'm good to merge. That book looks great.

On Sun, Sep 30, 2018 at 6:21 PM Dan Allen notifications@github.com wrote:

Oh, this is fantastic. I've been meaning to do this forever. Thanks for taking the lead on this. Are you good to merge?

After I merge, I'm going to follow up and add a reference to https://svgontheweb.com/. That's a really nice book for learning how to use SVG effectively on the web, which is good prerequisite knowledge for using SVG in AsciiDoc.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/asciidoctor/asciidoctor.org/pull/810#issuecomment-425695596, or mute the thread https://github.com/notifications/unsubscribe-auth/AApL322VV7rZ1_pDO1mhl5UF5C60wzwcks5ugFTegaJpZM4XAzqv .

--

-- Private or confidential message? Public Key available here https://pgp.mit.edu/pks/lookup?search=dan.mulholland%40gmail.com&op=index :

mojavelinux commented 5 years ago

I rebased, made some revisions, got the inline SVG working (stupid Awestruct), and added the recommended reading. Let's do this!

mojavelinux commented 5 years ago

Thanks!!