search

asciidoctor / asciidoctor.org

:globe_with_meridians: Asciidoctor project site. Composed in AsciiDoc. Baked with Awestruct.
https://asciidoctor.org
Other
323 stars 803 forks source link

Document the opts=optional attribute which can be used for an inclu… #881

Closed jwillemsen closed 5 years ago

jwillemsen commented 5 years ago

…de directive and fixed one typo

mojavelinux commented 5 years ago

Awesome! Thanks!

It needs one correction before it can be merged. The optional option is specified using opts=optional (not optional-option). Could you update?

Also, would you be willing to add a sentence that explains that when the optional option is set, the processor will ignore the directive if the target cannot be found? (meaning no warning is shown).

jwillemsen commented 5 years ago

I will make an update tomorrow and test your proposed change, optional-option does seem to work

mojavelinux commented 5 years ago

optional-option does seem to work

While I agree that's true, it's matching the internal name used to track the option, and thus should be avoided.

mojavelinux commented 5 years ago

Thanks!