search

asciidoctor / asciidoctor.org

:globe_with_meridians: Asciidoctor project site. Composed in AsciiDoc. Baked with Awestruct.
https://asciidoctor.org
Other
322 stars 807 forks source link

Broken link to Ruby API documentation #923

Closed owenh000 closed 4 years ago

owenh000 commented 4 years ago

In the Using the Ruby API section of the User Manual, there is a broken link to the "public APIs in Asciidoctor". The source is at docs/_includes/require-asciidoctor.adoc.

I suppose this should link to https://www.rubydoc.info/gems/asciidoctor instead, as in the References and Developer Resources section.

owenh000 commented 4 years ago

See pull request #924.

owenh000 commented 4 years ago

See also related issue #925 https://github.com/asciidoctor/asciidoctor/issues/3554.

mojavelinux commented 4 years ago

I merged the PR so I think this is now resolved. Please confirm.

In the future, can you add "resolves xyz" to the start of the PR subject?

owenh000 commented 4 years ago

Please confirm.

It appears to be fixed now, thanks.

add "resolves xyz" to the start of the PR subject

I'll try to remember to do that.