search

asciidoctor / asciidoctor.org

:globe_with_meridians: Asciidoctor project site. Composed in AsciiDoc. Baked with Awestruct.
https://asciidoctor.org
Other
322 stars 807 forks source link

Update Awestruct to 0.6.1, Asciidoctor to 2.0.10 #950

Closed zbynek closed 4 years ago

zbynek commented 4 years ago

For Awestruct changelog see https://github.com/awestruct/awestruct/releases

The change in docs/asciidoctor-gradle-plugin.adoc is to make sure new Asciidoctor doesn't show warnings about footnoteref used in the old version of the Gradle plugin readme.

zbynek commented 4 years ago

@mojavelinux did you have time to check this?

mojavelinux commented 4 years ago

Please split these changes up. Upgrading the reference for the Gradle plugin is definitely a separate issue from upgrading the site software.

I cannot just update Asciidoctor without also integrating any changes that were made to the default stylesheet. And the change from 1.5.7 to 2.0.10 is substantial, so it must be handled carefully.

I'm fine with updating Awestruct, but again, make that a separate PR.

Thanks!

zbynek commented 4 years ago

Thanks for the prompt answer. I created PRs for Awestruct and Gradle plugin. I think I'll leave updating Asciidoctor to someone more qualified.

mojavelinux commented 4 years ago

:+1: