asciidoctor / asciidoctorj-diagram

AsciidoctorJ Diagram bundles the Asciidoctor Diagram RubyGem (asciidoctor-diagram) so it can be loaded into the JVM using JRuby.
Apache License 2.0
10 stars 6 forks source link

Cannot use jsyntrax (update to asciidoctor-diagram 2.3.1?) #53

Closed inponomarev closed 4 months ago

inponomarev commented 4 months ago

Hello,

Per https://github.com/asciidoctor/asciidoctor-diagram/issues/423, asciidoctor-diagram 2.3.1 now pulls jsyntrax via a wrapper ruby gem. However, this is still not available in asciidoctorj-diagram, which is v. 2.3.0.

Do we need to create a new asciidoctorj-diagram-jsyntrax submodule for that?

robertpanzer commented 4 months ago

I started efforts yesterday on upgrading to asciidoctor-diagram 2.3.1. It will take me some time though to understand what has been added, what new dependencies are etc.

robertpanzer commented 4 months ago

I've staged a build at https://oss.sonatype.org/content/repositories/orgasciidoctor-1349 It would be good if you could try it out. Please note that the dependency on asciidoctorj-diagram-jsyntrax has to be specified explicitly:

    <build>
        <plugins>
            <plugin>
                <groupId>org.asciidoctor</groupId>
                <artifactId>asciidoctor-maven-plugin</artifactId>

                <configuration>
                    <requires>
                        <require>asciidoctor-diagram</require>
                    </requires>
                </configuration>
                <dependencies>
                    <dependency>
                        <groupId>org.asciidoctor</groupId>
                        <artifactId>asciidoctorj-diagram</artifactId>
                        <version>2.3.1</version>
                    </dependency>
                    <dependency>
                        <groupId>org.asciidoctor</groupId>
                        <artifactId>asciidoctorj-diagram-jsyntrax</artifactId>
                        <version>1.38.1</version>
                    </dependency>
                </dependencies>
            </plugin>
        </plugins>
    </build>

    <pluginRepositories>
        <pluginRepository>
            <id>staging</id>
            <releases>
                <enabled>true</enabled>
            </releases>
            <url>https://oss.sonatype.org/content/repositories/orgasciidoctor-1349</url>
        </pluginRepository>
    </pluginRepositories>
inponomarev commented 4 months ago

Hi @robertpanzer ! I checked it per your suggestion and it works perfectly -- no need to manually download & set up jsyntrax anymore! 🤗

robertpanzer commented 4 months ago

Thanks for checking. I'll release this then.

robertpanzer commented 4 months ago

The new release is on Maven central.