search

asciidoctor / asciidoctorj-diagram

AsciidoctorJ Diagram bundles the Asciidoctor Diagram RubyGem (asciidoctor-diagram) so it can be loaded into the JVM using JRuby.
Apache License 2.0
10 stars 6 forks source link

Update to asciidoctor-diagram 2.0.5 #8

Closed pepijnve closed 3 years ago

pepijnve commented 3 years ago

@robertpanzer I've tried to fix the unit tests a bit. They don't work with asciidoctorj 1.5.8 yet I'm afraid. The necessary bits of information are simply not getting passed on to the extension. If you really want to pin down where the images and cache files get written in the tests it would be better to set the imagesoutdir and diagram-cachedir attributes.

robertpanzer commented 3 years ago

@pepijnve Sorry, I completely forgot to push the 2.0.4 release. I just did that, and of course (sorry!) it results in a merge conflict. Could you please resolve that once you find some time?

And thank you so much for doing this pull request and all your great work on asciidoctor-diagram!

pepijnve commented 3 years ago

Conflicts resolved.

robertpanzer commented 3 years ago

Awesome, thank you!