search

asciidoctor / asciidoctorj-groovy-dsl

A Groovy DSL that allows for easy definition of Asciidoctor extensions
Apache License 2.0
14 stars 3 forks source link

Provide AsciidoctorJ 1.6.0 compatibility #11

Closed abelsromero closed 7 years ago

abelsromero commented 7 years ago

As discussed in the forum http://discuss.asciidoctor.org/Default-horizontal-style-for-labelled-lists-tp5400p5432.html, some extensions require to use AsciidoctorJ 1.6.x preview, but this cannot be used from the gradle-plugin extensions DSL property due to class name changes.

We could try some groovish thing and use dymanic typing to allow compatibility for 1.5.x and 1.6.0 branches, or create a separate branch for 1.6.0. I am more inclined on the brach option, even if it involves more work, it is much cleaner.

robertpanzer commented 7 years ago

I completely agree with you. If somebody changes the dependency in the Asciidoctor-Gradle-Plugin to use an AsciidoctorJ alpha version I think it should also be possible to change the version of the Groovy DSL. That should save us a lot of headache.

abelsromero commented 7 years ago

Do you think you can make a release on bintray? That way is it available from gradle.

robertpanzer commented 7 years ago

Just pushed a release :)