asciidoctor / asciidoctorj-pdf

AsciidoctorJ PDF bundles the Asciidoctor PDF RubyGem (asciidoctor-pdf) so it can be loaded into the JVM using JRuby.
Apache License 2.0
36 stars 17 forks source link

don't make build fail on outdated sources for mongodb #32

Closed ahus1 closed 4 years ago

ahus1 commented 4 years ago

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

[ ] Bug fix [ ] New non-breaking feature [ ] New breaking feature [ ] Documentation update [x] Build improvement

Description

What is the goal of this pull request? Make build run on Travis again

How does it achieve that? There was a mongo db repo that wasn't reachable any more, and apt-get didn't reach it.

Are there any alternative ways to implement this? Maybe there could have been a selective apt-get statement, or to just ignore the error; two options that I dismissed.

Are there any implications of this pull request? Anything a user must know? The build still fails in a later step: while the local "check" succeeds, test-asciidoctor-upstream.sh now fails. This is unrelated.

Other The failed tests are written to the console in more detail. Builds in other repos don't notify the IRC channel any more.

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc (none)