Closed robertpanzer closed 4 years ago
Upstream build on Travis passed with this change.
@mojavelinux Is it good to add the data/themes directory to the jar? I cannot remember the reason why it was excluded in the first place.
It should be included, yes.
Upstream tests ftw!
Kind of change
[X] Bug fix [ ] New non-breaking feature [ ] New breaking feature [ ] Documentation update [ ] Build improvement
Description
What is the goal of this pull request?
Currently the upstream build fails with this error:
It looks like the themes are required now. This PR tries to fix that.
How does it achieve that?
It adds the directory data/themes to the jar, which was excluded previously.
Are there any alternative ways to implement this?
Not that I am aware of if that change in asciidoctor-pdf upstream is intended.
Are there any implications of this pull request? Anything a user must know?
Bundle size increased by 20Kb
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #Issue
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc