search

asciidoctor / asciidoctorj-pdf

AsciidoctorJ PDF bundles the Asciidoctor PDF RubyGem (asciidoctor-pdf) so it can be loaded into the JVM using JRuby.
Apache License 2.0
36 stars 17 forks source link

Upgrade to asciidoctor-pdf 1.5.0-alpha.15 #5

Closed robertpanzer closed 7 years ago

robertpanzer commented 7 years ago

This PR updates asciidoctor-pdf to the latest version 1.5.0-alpha.15.

Notable change that I had to do is upgrade thread_safe to 0.3.6. It seems to run fine though with two versions on the class path, 0.3.5 from asciidoctorj and 0.3.6 from asciidoctorj-pdf.

mojavelinux commented 7 years ago

It seems to run fine though with two versions on the class path, 0.3.5 from asciidoctorj and 0.3.6 from asciidoctorj-pdf.

RubyGems automatically picks the newest version when there are multiple on the classpath.

mojavelinux commented 7 years ago

If you force push to this branch, the Travis CI job will run.

https://travis-ci.org/asciidoctor/asciidoctorj-pdf

robertpanzer commented 7 years ago

Only updated the timestamp of the commit and force-pushed. Seems like Travis has picked up the change 🍺

robertpanzer commented 7 years ago

Whee! Build passed. I'll try it out on Windows over the weekend. If that works as well I could do a release then.

robertpanzer commented 7 years ago

The build seems to run fine on Windows, except that the Rouge Gem still fails to load.

robertpanzer commented 7 years ago

Using Rouge also fails on Windows if I use the older version 1.11.1 with the same error I mentioned in #4 Not sure how we want to handle this. I am a bit hesitant to release this with rouge not working on Windows. OTOH I tried the asciidoctorj-pdf 1.5.0-alpha.11 on Windows with a JRuby 1.7.xx and that doesn't work either.

mojavelinux commented 7 years ago

I don't understand how that's possible given that rouge is a pure Ruby gem with no dependencies. Is there any indication of what the error is?

The only thing I can think of is this very strange way of requiring files that Rouge uses. See https://github.com/jneen/rouge/blob/ec665bb2ccac767874e85c5b9d6fdefbf471058e/lib/rouge.rb#L36-L79.

mojavelinux commented 7 years ago

Not sure how we want to handle this.

If it has never worked, we really aren't breaking anything that isn't already broken. Therefore, we should move forward and deal with this problem independently.