search

asciidoctor / asciidoctorj-pdf

AsciidoctorJ PDF bundles the Asciidoctor PDF RubyGem (asciidoctor-pdf) so it can be loaded into the JVM using JRuby.
Apache License 2.0
35 stars 17 forks source link

Upgrade asciidoctor-pdf to 1.6.2 #68

Closed robertpanzer closed 2 years ago

robertpanzer commented 2 years ago

Just upgrades asciidoctor-pdf to 1.6.2.

A preview with this PR is available for testing from the maven repo https://oss.sonatype.org/content/repositories/orgasciidoctor-1283/

robertpanzer commented 2 years ago

It seems like the upstream build no longer works with Java 11. With Java 11 the gem-maven-plugin 1.1.8 seems to fail with an error. If I upgrade to 2.0.0-1 or 2.0.1 the following Gradle build fails as the pom file that was generated by the gem-maven-plugin is incomplete. It literally ends in the middle of the xml content. That's both on Java 8 and Java 11.

I am leaning towards running the upstream build with Java 8. Wdyt?

robertpanzer commented 2 years ago

Ah, now I see that the PR build against the released version and the upstream version are separate flows. Since I could run the upstream build locally against Java 8 I think the PR itself is fine.

robertpanzer commented 2 years ago

Also upgraded rouge to the current version 3.27.0. Or should I just remove it from asciidoctorj-pdf if the requirement is asciidoctor 2.x.x anyway?