search

asciidoctor / asciidoctorj-pdf

AsciidoctorJ PDF bundles the Asciidoctor PDF RubyGem (asciidoctor-pdf) so it can be loaded into the JVM using JRuby.
Apache License 2.0
35 stars 17 forks source link

Fix css parser #86

Closed robertpanzer closed 1 year ago

robertpanzer commented 1 year ago

Thank you for opening a pull request and contributing to AsciidoctorJ PDF!

Please take a bit of time giving some details about your pull request:

Kind of change

[x] Bug fix [ ] New non-breaking feature [ ] New breaking feature [ ] Documentation update [ ] Build improvement

Description

What is the goal of this pull request?

Fix the CI build.

How does it achieve that?

The CI build is broken since a new version of css_parser, 1.13.0, was released, that requires Ruby 2.7 which is not supported by JRuby 9.3.8.0. Since we don't have a released version of AsciidoctorJ yet that uses JRuby 9.4.0.0 this PR fixes the version of the css_parser gem to the last compatible version, 1.12.0.

Unrelated, I also upgraded gradle to the latest version, 7.6.

Are there any alternative ways to implement this?

We could release a new version of AsciidoctorJ using JRuby 9.4.0.0 which should theoretically allow to use css_parser 1.13.0. Risks are though that this would not allow using ascidoctorj-pdf with an older version of AsciidoctorJ.

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc