search

asciidoctor / asciidoctorj-pdf

AsciidoctorJ PDF bundles the Asciidoctor PDF RubyGem (asciidoctor-pdf) so it can be loaded into the JVM using JRuby.
Apache License 2.0
35 stars 17 forks source link

Remove 'rouge' gem, already provided by AsciidoctorJ #88

Closed abelsromero closed 1 year ago

abelsromero commented 1 year ago

Kind of change

[ ] Bug fix [x] New non-breaking feature [ ] New breaking feature [ ] Documentation update [ ] Build improvement

Description

What is the goal of this pull request? Remove 'rouge' gem, already provided by AsciidoctorJ. It also enables Java 8 for macos and adds CHANGELOG.

How does it achieve that? Simply removing the dependency the gem is not packaged in the jar.

Are there any alternative ways to implement this? No

Are there any implications of this pull request? Anything a user must know? Not that I am aware.

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #87

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

robertpanzer commented 1 year ago

Totally makes sense.