asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
627 stars 172 forks source link

Upgrade remaining dependency on junit 4.12 to 4.13.2 #1044

Closed robertpanzer closed 3 years ago

robertpanzer commented 3 years ago

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

Description

What is the goal of this pull request?

Sonatype sent a warning that we are still relying on unit 4.12 which has an open CVE. Indeed asciidoctorj-test-support still has that dependency even though the build itself should already have used the fixed version 4.13.2. This PR upgrades this last remaining dependency to 4.13.2 too to avoid that CVE.

How does it achieve that?

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc