search

asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
627 stars 172 forks source link

Bump SpringBoot version to latest 2.5.2 in it test #1048

Closed abelsromero closed 3 years ago

abelsromero commented 3 years ago

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

Description

What is the goal of this pull request?

Upgrade version of Spring Boot version used in the Spring Boot integration test.

How does it achieve that?

Simply upgrade the configuration of the submodule springboot-app. It also removes an unnecessary asciidoctorj version property.

Are there any alternative ways to implement this?

If necessary we could consider parameterizing the version in a way that allowed to run the same test against several version, por example the 2 most recent minnors. But that can be tricky when we fund breaking changes between minors.

Are there any implications of this pull request? Anything a user must know? No.

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

robertpanzer commented 3 years ago

Thanks! 🥳