asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
627 stars 172 forks source link

Fixes for CI pipelines #1056

Closed abelsromero closed 3 years ago

abelsromero commented 3 years ago

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

Description

What is the goal of this pull request?

Fixes in pipelines

How does it achieve that?

Are there any alternative ways to implement this?

No that I know.

Are there any implications of this pull request? Anything a user must know?

I'd also like to split "Test upstream" in a different job so it's shown in the actions UI and we don't miss it again. It will require some config duplication but I think it's worth it.

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

robertpanzer commented 3 years ago

Thanks! I somehow missed checking the changes when upgrading from setup-java v1 to v2.

abelsromero commented 3 years ago

I'd also like to split "Test upstream" in a different job so it's shown in the actions UI and we don't miss it again. It will require some config duplication but I think it's worth it.

opinions on ☝️ ?

robertpanzer commented 3 years ago

I would be fine with that.