Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
[x] Bug fix
[ ] New non-breaking feature
[ ] New breaking feature
[ ] Documentation update
[ ] Build improvement
Description
What is the goal of this pull request?
Fix the issue #1096.
Calling Document.findBy() should not result in a ClassCastException.
How does it achieve that?
Make Cell extend StructuralNode instead of ContentNode. That way the ClassCastException does not happen anymore since Document.findBy() returns a List<StructuralNode>
Are there any alternative ways to implement this?
Make Document.findBy() return a List<ContentNode>. However, afaict, this doesn't make much sense.
Are there any implications of this pull request? Anything a user must know?
No.
It's currently on the main branch which eventually results in the next major version.
However, according to https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html, it should even be possible to backport this to the current 2.x line and publish a new bugfix release.
Issue
If this PR fixes an open issue, please add a line of the form:
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
Description
What is the goal of this pull request?
Fix the issue #1096. Calling Document.findBy() should not result in a ClassCastException.
How does it achieve that?
Make Cell extend StructuralNode instead of ContentNode. That way the ClassCastException does not happen anymore since
Document.findBy()
returns aList<StructuralNode>
Are there any alternative ways to implement this?
Make
Document.findBy()
return aList<ContentNode>
. However, afaict, this doesn't make much sense.Are there any implications of this pull request? Anything a user must know?
No. It's currently on the main branch which eventually results in the next major version. However, according to https://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html, it should even be possible to backport this to the current 2.x line and publish a new bugfix release.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #1096