asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
627 stars 172 forks source link

Fix upstream test #1123

Closed abelsromero closed 2 years ago

abelsromero commented 2 years ago

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

Description

What is the goal of this pull request?

Fix upstream tests.

How does it achieve that?

Force "-SNAPSHOT" suffix to upstream version to install gem consistently. gem-maven-plugin appends it when the gem version is not strictly semver installing a gem with "-SNAPSHOT" in the version but not in the maven repo path.

Are there any alternative ways to implement this?

Tried a few things as mentioned here https://github.com/asciidoctor/asciidoctorj/pull/1121#issuecomment-1273907410, option 3 did not work in CI, and this seemed to me the more consistent. We get the sama version format and install path always.

I don't discard spending some extra time with gem-maven-plugin but this depends on time :$

Are there any implications of this pull request? Anything a user must know?

No

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

robertpanzer commented 2 years ago

Awesome, thank you, @abelsromero 🚀