Issue 1120 replace deprecated numbered by sectnums v2.5.x

asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!

http://asciidoctor.org

Apache License 2.0

624 stars 173 forks source link

Issue 1120 replace deprecated numbered by sectnums v2.5.x #1127

Closed robertpanzer closed 1 year ago

robertpanzer commented 1 year ago

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

[ ] Bug fix
[ ] New non-breaking feature
[ ] New breaking feature
[ ] Documentation update
[ ] Build improvement

Description

This PR cherry picks #1124 into the v2.5.x branch.

abelsromero commented 1 year ago

I did not even realize v2.5.x was being maintained and comparing the branches I see some changes that seems to me should be ported (docs, gradle bump for instance). What is the policy for porting changes from main?

robertpanzer commented 1 year ago

I bumped the version on main to 3.0.0-SNAPSHOT a while ago after merging 2 breaking changes. Everything that qualifies as a non-breaking change should also go into v2.5.x. (I am usually doing this right now)