asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
623 stars 173 forks source link

Expose Document's source and source_lines properties #1145

Closed abelsromero closed 1 year ago

abelsromero commented 1 year ago

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

Description

What is the goal of this pull request? Expose Document's source and source_lines properties. This is required to be able to use other asciidoctor components like asciidoctor-reducer.

How does it achieve that? Using already present AsciidoctorJ APIs and practices, nothing special.

Are there any alternative ways to implement this? Not that I know.

Are there any implications of this pull request? Anything a user must know? No

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #1143

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

abelsromero commented 1 year ago

Btw, I assume this is fine going to 3.0.0? Or a 2.5.8 is planned? No issue at all backporting it if necessary.

robertpanzer commented 1 year ago

Yes, main would be 3.0.0. We can also do a 2.5.8, that contains this change.

abelsromero commented 1 year ago

We can also do a 2.5.8, that contains this change.

If people do not ask for it, I would not do it.

abelsromero commented 1 year ago

Changes done, anything else needs improving? :eyes:

robertpanzer commented 1 year ago

Thank you! Looks good!