asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
623 stars 173 forks source link

Set Java11 as minimal version #1151

Closed abelsromero closed 1 year ago

abelsromero commented 1 year ago

Kind of change

Description

What is the goal of this pull request?

Remove support for Java 8 and set 11 as de minimal version. Java8 is EOL and I don't think we should promote using it.

How does it achieve that?

Are there any alternative ways to implement this?

task.options.release still works, but Gradle docs suggest using the new toolchain configuration as this is the "preferred".

Are there any implications of this pull request? Anything a user must know?

Users using Java 8 should stay in 2.5.x until they upgrade their apps.

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #1150

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

abelsromero commented 1 year ago

Should we create a "Breaking changes" section in the CHANGELOG? I think it'd make the release notes much more simple when the time comes.

abelsromero commented 1 year ago

Running tests in my repo to see if we can find a workaround for the Windows+Java17 issue.

abelsromero commented 1 year ago

Fixed the issue by forcing the toolchain version manually on Windows builds ONLY. It's sad but simple enough that with a simple comment, we can monitor it and remove it if it ever gets fixed. I am also keeping it in a separate commit, since AsciidoctorJ uses "merge pr" that will also make things easier to track.

Since the release pipeline runs already on Java 11, there won't compatibility issues. The release will be 100% J11 binary.