Deprecate destinationDir option for v2.5.x - Githubissues

asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!

http://asciidoctor.org

Apache License 2.0

623 stars 173 forks source link

Deprecate destinationDir option for v2.5.x #1154

Closed abelsromero closed 1 year ago

abelsromero commented 1 year ago

Kind of change

[x] Bug fix
[ ] New non-breaking feature
[x] New breaking feature
[ ] Documentation update
[ ] Build improvement

Description

What is the goal of this pull request? Fix the option to set toDir internally. Deprecate the option to warn users it is being removed in v3.0.x.

How does it achieve that? Set toDir and add deprecation documentation.

Are there any alternative ways to implement this? No

Are there any implications of this pull request? Anything a user must know? No

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #853 Fixes #941

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

robertpanzer commented 1 year ago

Thank you!