search

asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
623 stars 173 forks source link

Add required '--add-opens' to cli script #1156

Closed abelsromero closed 1 year ago

abelsromero commented 1 year ago

Kind of change

Description

What is the goal of this pull request?

Remove WARN FilenoUtil : Native subprocess control requires open access to the JDK IO subsystem message at least when running the CLI.

How does it achieve that?

Simply adds required --add-open options.

Are there any alternative ways to implement this? No.

Are there any implications of this pull request? Anything a user must know? This is not related to https://github.com/asciidoctor/asciidoctorj/issues/1034, and does not fix it.

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #1155

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

abelsromero commented 1 year ago

If this is fine, I'll port to branch 2.5.x.

robertpanzer commented 1 year ago

Thank you!

When porting this to v2.5.x, wouldn't the script fail when running with Java 8?

abelsromero commented 1 year ago

When porting this to v2.5.x, wouldn't the script fail when running with Java 8?

I'll test, in that case we can document it at least. We'd had a couple of questions about it in the maven plugin and at least that way we have an official statement and explanation.

bubbasnmp commented 1 month ago

Will you pull this into the v2.5.x or is there a schedule for v3?