We could make further tests and check if the property has the ':chapter' object. But the current implementation already meets the tests, so I see no point in complicating it.
Also, it does not tests doctype manpage and inline since in those the sections are not taken into consideration or cannot be numbered (manpage).
For reference, I left a comment pointing to the issue in the code.
Are there any implications of this pull request? Anything a user must know?
Includes a couple of minor improvements to RubyObjectWrapper but all the tests pass :ok:
Issue
If this PR fixes an open issue, please add a line of the form:
Closes #1122
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc
I don't think is worth mentioning.
robertpanzer
commented
1 year ago
Kind of change
Description
What is the goal of this pull request?
Mainly provide some closure to issue #1122.
How does it achieve that?
Test Section.isNumbered to ensure expected behavior
Are there any alternative ways to implement this?
We could make further tests and check if the property has the ':chapter' object. But the current implementation already meets the tests, so I see no point in complicating it. Also, it does not tests doctype
manpageandinlinesince in those the sections are not taken into consideration or cannot be numbered (manpage). For reference, I left a comment pointing to the issue in the code.Are there any implications of this pull request? Anything a user must know?
Includes a couple of minor improvements to
RubyObjectWrapperbut all the tests pass :ok:Issue
If this PR fixes an open issue, please add a line of the form:
Closes #1122
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc I don't think is worth mentioning.