Closed abelsromero closed 1 year ago
What is the goal of this pull request?
Replace deprecated 'headerFooter' by 'standalone'
How does it achieve that?
Simply rename method and change the use of the header_footer option in the internal map by standalone.
header_footer
standalone
Are there any alternative ways to implement this?
We could have deprecated the headerFooter method but since this is for v3.0.0...breaking changes are ok. I'll create a PR to deprecate in v2.5.x
headerFooter
Are there any implications of this pull request? Anything a user must know? No.
If this PR fixes an open issue, please add a line of the form:
Fixes #1160
Please add a corresponding entry to the file CHANGELOG.adoc
Thank you!
Kind of change
Description
What is the goal of this pull request?
Replace deprecated 'headerFooter' by 'standalone'
How does it achieve that?
Simply rename method and change the use of the
header_footer
option in the internal map bystandalone
.Are there any alternative ways to implement this?
We could have deprecated the
headerFooter
method but since this is for v3.0.0...breaking changes are ok. I'll create a PR to deprecate in v2.5.xAre there any implications of this pull request? Anything a user must know? No.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #1160
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc