asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
624 stars 173 forks source link

(v2.5.x) Deprecate 'headerFooter' in favour of 'standalone' #1162

Closed abelsromero closed 1 year ago

abelsromero commented 1 year ago

Kind of change

Description

What is the goal of this pull request?

Deprecate 'headerFooter' in favour of 'standalone'

Related to https://github.com/asciidoctor/asciidoctorj/pull/1161

How does it achieve that?

Simply add new method and change the use of the header_footer option in the internal map by standalone. The old option is still accepted in the map, hence the check in AsciidoctorUtils.

Are there any alternative ways to implement this?

No

Are there any implications of this pull request? Anything a user must know?

No, no breaking change introduced.

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #1160

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

abelsromero commented 1 year ago

Any idea why CI is not running for this branch? :thinking: It's set in the config

robertpanzer commented 1 year ago

I have no idea as well unfortunately. I wanted to spend some more time digging into this, but recently I barely find any time. Do you have any idea?

abelsromero commented 1 year ago

I have no idea as well unfortunately. I wanted to spend some more time digging into this, but recently I barely find any time. Do you have any idea?

Nop, but should be easy 🤞 I'll check in my fork later.

robertpanzer commented 1 year ago

Thank you!