asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
623 stars 173 forks source link

Enable GH actions on branch 2.5.x #1165

Closed abelsromero closed 1 year ago

abelsromero commented 1 year ago

Kind of change

Description

What is the goal of this pull request?

Fix pipelines not running on PR on branch v2.5.x

How does it achieve that?

Pretty obvious fix in the configuration :sweat_smile: GH reads from the PR file, not the on main branch. I'll reuse the open PR on main to remove 2.5 from that.

Are there any alternative ways to implement this? No

Are there any implications of this pull request? Anything a user must know? No

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

Not worth mentioning I think.

abelsromero commented 1 year ago

ruby proxy torquebox is returning a dubious website, and I don't think this is going to be a quick fix. If no one objects, I'd like to merge this to rebase open PRs :roll_eyes:

robertpanzer commented 1 year ago

Thank you so much! How could I oversee that🤦‍♂️