search

asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
625 stars 173 forks source link

Asciidoctor.convert() never returns Documents. #1175

Closed robertpanzer closed 1 year ago

robertpanzer commented 1 year ago

As mentioned by @abelsromero in #1171 the method Asciidodctor.convert() never returns a Document, even though the caller asks for a org.asciidoctor.ast.Document. The implementation of this method should use the NodeConverter and try to convert the result returned by Asciidoctor.

abelsromero commented 1 year ago

Addressed in PR https://github.com/asciidoctor/asciidoctorj/pull/1171, I think we can close this issue?

robertpanzer commented 1 year ago

Yes, totally! Thanks for fixing it.