asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
625 stars 173 forks source link

(v2.5.x) Fix CI upstream tests #1180

Closed abelsromero closed 1 year ago

abelsromero commented 1 year ago

Kind of change

Description

What is the goal of this pull request?

TLDR; Fix CI upstream tests, same as https://github.com/asciidoctor/asciidoctorj/pull/1179 but for v2.5.x branch.

How does it achieve that?

Since we need compatibility with Java 8, this PR only does minimal changes (unlike https://github.com/asciidoctor/asciidoctorj/pull/1179). Simply remove the gem packaging.

Also bump jruby version, not strictly necessary, but I'd rather be on latests versions, you can't never be too paranoid about security.

Are there any alternative ways to implement this?

Same considerations as in https://github.com/asciidoctor/asciidoctorj/pull/1179.

Are there any implications of this pull request? Anything a user must know?

Yes, always keep your CI healthy green_circle

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #1178

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

robertpanzer commented 1 year ago

I had to remove the pluginRepository to get it running locally:

diff --git a/ci/asciidoctor-gem-installer.pom b/ci/asciidoctor-gem-installer.pom
index e03ca15..67230bc 100644
--- a/ci/asciidoctor-gem-installer.pom
+++ b/ci/asciidoctor-gem-installer.pom
@@ -14,12 +14,6 @@
             <url>http://rubygems-proxy.torquebox.org/releases</url>
         </repository>
     </repositories>
-    <pluginRepositories>
-        <pluginRepository>
-            <id>rubygems-releases</id>
-            <url>https://rubygems-proxy.torquebox.org/releases</url>
-        </pluginRepository>
-    </pluginRepositories>
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     </properties>
abelsromero commented 1 year ago

Nevermind this branch, I am looking at the main branch in my fork. It's driving me crazy the nightly scheduled run is successful but the PRs are not :hankey:

abelsromero commented 1 year ago

Main branch is completed (if only for improvements), back to this one, I will be testing in my fork, don't worry if there's no activity here. I'll mark as ready when ready.

abelsromero commented 1 year ago

At the end ported the formatting improvements from main branch and it works fine now.

robertpanzer commented 1 year ago

Thanks a lot!