Add new Link interface and accessors methods to Catalog interface.
There are also some improvements to javadocs to ImageReference.
Are there any alternative ways to implement this?
Original links in Asciidoctor are just a string and I could have gone with just that. But I decided to wrap them in an Java interface to protect from future evolutions. I can imagine maybe at some point Link also contain information about the text or attributes being applied in the macro.
Are there any implications of this pull request? Anything a user must know?
No
Issue
Fixes #1183
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc
robertpanzer
commented
1 year ago
Kind of change
Description
What is the goal of this pull request? Expose Links in the Catalog Assest to offer the same features as in core Asciidoctor https://docs.asciidoctor.org/asciidoctor/latest/api/catalog-assets/.
How does it achieve that?
Add new Link interface and accessors methods to Catalog interface.
There are also some improvements to javadocs to ImageReference.
Are there any alternative ways to implement this?
Original links in Asciidoctor are just a string and I could have gone with just that. But I decided to wrap them in an Java interface to protect from future evolutions. I can imagine maybe at some point Link also contain information about the text or attributes being applied in the macro.
Are there any implications of this pull request? Anything a user must know? No
Issue
Fixes #1183
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc