asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
617 stars 172 forks source link

Remove test's report destination #1188

Closed abelsromero closed 1 year ago

abelsromero commented 1 year ago

I think this Gradle customization could be removed.

asciidoctorj-core and asciidoctorj-wildfly-integration-test customize the destination path of test reports with

  reports {
    html {
      destination file("$buildDir/reports/${task.name}")
    }
    junitXml {
      destination file("$buildDir/${task.name}-result")
    }
  }

But the default configuration for reports already separates them by task:

Maybe this was necessary at some point but does not seem the case now. Removing it we can safe a few lines :grin:

NOTE: if the change is applied, we need to update the path of the upload artifacts step in CI.

robertpanzer commented 1 year ago

Sounds good! The more we can rely on the conventions the better.