asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
617 stars 172 forks source link

(v2.5.x) Remove unnecessary tests reports destination #1190

Closed abelsromero closed 1 year ago

abelsromero commented 1 year ago

Kind of change

Description

What is the goal of this pull request?

Simplify Gradle configuration removing an unnecessary configuration, see #1188 for details

How does it achieve that?

Just removes it, no other changes are necessary, reports path in CI still match.

Are there any alternative ways to implement this?

No :thinking:

Are there any implications of this pull request? Anything a user must know?

No

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #1188

Release notes

This is an internal change, I don't think it's worth adding to changelog.

abelsromero commented 1 year ago

~Waiting (draft) until the JUnit 5 PR is merged, I suspect there will be conflicts.~

Silly me, unless someone shows interest, no plan on porting JUnit5 to this branch, which is in maintenance.

robertpanzer commented 1 year ago

Thank you! You're right, let's not put the effort of moving to JUnit5 into 2.5.x.