asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
617 stars 172 forks source link

Use junit-pioneer to simplify polluted tests #1194

Closed abelsromero closed 1 year ago

abelsromero commented 1 year ago

Kind of change

Description

What is the goal of this pull request?

Simplify Gradle build and fix some IDE integration issues. See #1193 for details.

How does it achieve that?

Are there any alternative ways to implement this?

Discussed in #1193.

Are there any implications of this pull request? Anything a user must know?

No, if anything, it should be easier for contributors now.

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #1193

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

abelsromero commented 1 year ago

I added the missing Asciidoctor Factory cases and asserted them based on the returned values. @robertpanzer cpould you please double-check nothing is wrong?

abelsromero commented 1 year ago

"drafting" while I look into the test that failed 😞

abelsromero commented 1 year ago

I had to apply a workaround for Windows builds only to set --add-opens to the test task. Not elegant but allows us to keep the code and overall configuration simpler than before.

robertpanzer commented 1 year ago

Thanks! 👍