Create mutable copies of options passed to Processor.create...()
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
[x] Bug fix
[ ] New non-breaking feature
[ ] New breaking feature
[ ] Documentation update
[ ] Build improvement
Description
What is the goal of this pull request?
Some methods of the Processor API to create nodes mutate the given attributes and options maps.
This is not only surprising, but apparently also fails with an exception if the given map is immutable.
This PR tries to fix this by creating a copy of the given map.
How does it achieve that?
Make a copy of the given map.
Are there any alternative ways to implement this?
I don't think so.
Are there any implications of this pull request? Anything a user must know?
Just in case, it should be impossible to mutate the given options after the Processor was called. This is likely made up, and makes assumptions of the internal behavior of AsciidoctorJ from the users perspective.
Create mutable copies of options passed to Processor.create...()
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
Description
What is the goal of this pull request?
Some methods of the Processor API to create nodes mutate the given attributes and options maps. This is not only surprising, but apparently also fails with an exception if the given map is immutable. This PR tries to fix this by creating a copy of the given map.
How does it achieve that?
Make a copy of the given map.
Are there any alternative ways to implement this?
I don't think so.
Are there any implications of this pull request? Anything a user must know?
Just in case, it should be impossible to mutate the given options after the Processor was called. This is likely made up, and makes assumptions of the internal behavior of AsciidoctorJ from the users perspective.
Issue
Fixes #1221