asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
617 stars 172 forks source link

Ensure AsciidoctorJ version is returned always in CLI #1230

Closed abelsromero closed 7 months ago

abelsromero commented 1 year ago

I see this null check https://github.com/asciidoctor/asciidoctorj/blob/6088e5b143646c8cd291542d9f95b55cbaaec0fb/asciidoctorj-cli/src/main/java/org/asciidoctor/cli/jruby/AsciidoctorInvoker.java#L93 and I wonder if we should remove it and ensure the version is always obtainable.

We could keep the check for resiliency, but log a message indicating something went wrong.