asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
617 stars 172 forks source link

Fixes #1135 on v2.5.x (#1241). Target file name should be relative to… #1242

Closed robertpanzer closed 7 months ago

robertpanzer commented 7 months ago

…tion dir if source dir is given.

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

Description

What is the goal of this pull request?

This PR fixes the behavior of the CLI to automatically set the mkdirs option similar to how the asciidoctor command does it. This was originally reported in #1137 which was fixed on the main branch for the next version 3.0.0 of AsciidoctorJ. Since it got erroneously classified as a breaking change this PR fixes the issue on the v2.5.x branch as well.

How does it achieve that?

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #1241

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

robertpanzer commented 7 months ago

As discussed will open 2 new PRs with separate changes for setting the mkdirs option and fixing the conversion into these created directories.