asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
617 stars 172 forks source link

(2.5.x) Bump java 19 to 21 #1245

Closed abelsromero closed 7 months ago

abelsromero commented 7 months ago

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

Description

What is the goal of this pull request?

Ensure v2.5.x is tested on Java 21.

How does it achieve that?

Add Java 21 to CI.

Are there any alternative ways to implement this?

No. I went with absolute minimal changes here. No Gradle, SpringBoot (test) neither. On Boot, v2.7 is out of support already, but we already test newer version in main branch.

Are there any implications of this pull request? Anything a user must know?

no

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

abelsromero commented 7 months ago

Nevermind, there's no Gradle (v7.x or v8.x) compatible with java 8 and java 21. I guess it's "best effort" for java 21