search

asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
617 stars 172 forks source link

Bump JRuby to v9.4.5.0 (fixes #1035) #1246

Closed abelsromero closed 7 months ago

abelsromero commented 7 months ago

Kind of change

Description

What is the goal of this pull request?

Fix issue #1035 as commented https://github.com/asciidoctor/asciidoctor-maven-plugin/issues/553#issuecomment-1793240139

How does it achieve that?

Yes, validated in maven runs and also building a custom distribution of AsciidoctorJ.

Are there any alternative ways to implement this?

n/a

Are there any implications of this pull request? Anything a user must know?

The only thing is that there's still another warning for Java > 13. But we can treat it in a separated PR.

OpenJDK 64-Bit Client VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #1035

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

abelsromero commented 7 months ago

@robertpanzer do you see any issue with this? I can merge myself if agree.

robertpanzer commented 7 months ago

Sorry for not being responsive, I am drowning a bit atm :D Thanks for the chore! 🙏

abelsromero commented 7 months ago

Sorry for not being responsive, I am drowning a bit atm :D

No problem, I was tempted to merge myself seeing all was working fine. But I still like to hear from you.