Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
[x] Bug fix
[ ] New non-breaking feature
[ ] New breaking feature
[ ] Documentation update
[ ] Build improvement
Description
What is the goal of this pull request?
This PR fixes the issue mentioned in #1265.
Column.setWidth will be honored if an extension calls Table#assignColumnWidths() after setting the column widths and adding the columns to the table (in addition to establishing the parent-child-relationship).
How does it achieve that?
Are there any alternative ways to implement this?
Column widths could be assigned whenever a column is added to a table, or when Column.setWidth is invoked.
This change would be very intrusive though.
Therefore, I found it better to have a way that requires calling a new method.
Are there any implications of this pull request? Anything a user must know?
Not really. Existing code is not touched.
Behavior only changes when a new method is invoked that didn't exist before.
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
Description
What is the goal of this pull request?
This PR fixes the issue mentioned in #1265. Column.setWidth will be honored if an extension calls Table#assignColumnWidths() after setting the column widths and adding the columns to the table (in addition to establishing the parent-child-relationship).
How does it achieve that?
Are there any alternative ways to implement this?
Column widths could be assigned whenever a column is added to a table, or when Column.setWidth is invoked. This change would be very intrusive though. Therefore, I found it better to have a way that requires calling a new method.
Are there any implications of this pull request? Anything a user must know?
Not really. Existing code is not touched. Behavior only changes when a new method is invoked that didn't exist before.
Issue
Fixes #1265