Closed amusarra closed 2 months ago
Please add a requires element for asciidoctor-diagram.
Yes, you can see how to do it in https://github.com/asciidoctor/asciidoctor-maven-examples/blob/20ba3920b2257afbf2c783b10d728626a421d3ee/asciidoctor-diagram-example/pom.xml#L60-L62. I tested and is working fine in my machine.
PS: @robertpanzer beat me to answer by seconds :sweat_smile:
Hi @robertpanzer and @abelsromero Thank you very much for the suggestion.
Why is this very important configuration not documented in the project's README and the rest of the documentation?
I assumed that by placing the dependency on the maven plugin configuration there was no need for anything else, usually Maven plugins work this way.
Could you update the configuration by indicating this important configuration item? What you suggested is not even indicated here https://docs.asciidoctor.org/maven-tools/latest/plugin/introduction/
Thanks again.
You are welcome to contribute to the documentation if you feel that it needs updating. This is an open source project that depends on contributions from the community. No one is responsible or obliged to make the software or documentation meet anyone else's needs.
Why is this very important configuration not documented in the project's README and the rest of the documentation?
I assumed that by placing the dependency on the maven plugin configuration there was no need for anything else, usually Maven plugins work this way.
I can see the confusion tbh. On one side asciidoctorJ-diagram bundles the Ruby Gem (the actual implementation) without any extra discovery logic, and on the other requires
could be better explained in https://docs.asciidoctor.org/maven-tools/latest/plugin/goals/process-asciidoc/#configuration-requires, it says "Ruby libraries" and we are adding a JAR.
But, asciidoctor-diagram configuration is very specific, is not an embedded component of the plugin, so I don't see reason to mention it in the introduction or README which contains the simplest "getting started" scenarios. For specifics, we have the examples repo which you saw and also link in the docs https://docs.asciidoctor.org/maven-tools/latest/plugin/examples/. And I am sorry to point it, but the diagram's example contains the require
configuration. Maybe we could add more info the respective readme in the example, or place a comment above the XML stating it's important. But there's not much we can do about assumptions.
Btw, I'd suggest we continue the conversation in the plugin repo , this story is solved to me and is unrelated to AsciidoctorJ. Different volunteers maintain each project and there's no point on creating notifications here.
Thanks so much. 👍
Hi. Following your examples, I created a Maven project to generate a PDF document from an asciidoc source. The source document contains Mermaid digraphs. When I run the
process-asciidoc
goal, I get the error in question.Followed by a Mermaid block which causes problems even though it shouldn't since it is syntactically correct and the IntellijIDEA plugin displays it correctly.
Below is the pom.xml file used.
The mmdc is installed by the command
npm install -g @mermaid-js/mermaid-cli
and available on$PATH
. The version of the mmdc -> 10.8.0.What's the problem?