search

asciidoctor / asciidoctorj

:coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!
http://asciidoctor.org
Apache License 2.0
627 stars 172 forks source link

Remove renderFile* methods from call stack #418

Open mojavelinux opened 8 years ago

mojavelinux commented 8 years ago

Since the renderFile* methods on the Asciidoctor API have been deprecated, we should remove them from the call stack so that they are only used if a deprecated method is used by the client. Right now, the methods are jumping back and forth between calls between renderFile and convertFile, which makes the call stack longer than it should.

In other words, isolate the two chains so that renderFile* calls into convertFile, but convertFile* never circles back to renderFile.

abelsromero commented 8 years ago

I've seen that the @Deprecated warning does not show in the IDE. I guess it's because it's only in the implementation and not the interface:

Should't it be on both, or at least in the interface?

mojavelinux commented 8 years ago

Definitely!