search

asciidoctor / atom-asciidoc-preview

⚛ AsciiDoc preview for the Atom editor.
https://atom.io/packages/asciidoc-preview
MIT License
142 stars 42 forks source link

Add support of PlantUML asciidoc extention #122

Open stasberkov opened 8 years ago

stasberkov commented 8 years ago

Add support of PlantUML asciidoc extention https://code.google.com/archive/p/asciidoc-plantuml/wikis/Usage.wiki as asciidocfx does

[uml, file="rtd-redesign.png"]
--
class Car

Driver - Car : drives >
Car *- Wheel : have 4 >
Car -- Person : < owns
--
stasberkov commented 8 years ago

Practice showed that such extension has low practical value. Proper way of editing documents with plant uml diagrams is to edit them independently (using dedicated planuml package for Atom) and then including into asciidoc document as images.

sylvek commented 7 years ago

@stasberkov i'm not agree with you.. having uml and text in a same document is more fluent than editing the uml diagram and extract a png.

MrUzai commented 7 years ago

Totally agreeing with @sylvek on this. Not being able to use plantuml in asciidoc is the major reason i'm still trying to document in markdown as markdown preview plus provides plantuml integration.

mojavelinux commented 7 years ago

Asciidoctor has support for plantuml using two different approaches, asciidoctor-diagram or asciidoctor-plantuml. The only challenge here is how to integrate this into the editor. The barrier there is that the editor is based on Asciidoctor.js and neither of these extensions has been transpiled to work in that environment. So that has to be done first in order to get support here. Or another extension is needed that is designed specifically for Asciidoctor.js.

mojavelinux commented 7 years ago

It's completely doable. It's just a matter of doing it ;)

ali-gs commented 6 years ago

Is there any update on this one? I am facing the same issue

AndersonDev commented 5 years ago

Any updates here?

Skilly commented 4 years ago

Like @sylvek and @MrUzai, I too disagree with the assertion that this suggestion has low practical value. Quite the contrary; even Visual Studio Code supports plantuml embedded in asciidoctor

tjallingran commented 4 years ago

kroki (GitHub) has support for rendering PlantUML. The VS Code Asciidoctor plugin uses that in combination with Asciidoctor.js, afaik.

Maybe that could work for atom-asciidoc as well.

That said, I write plantuml in separate files that I !include in my Asciidoc files, and I haven't managed to get the !included PlantUML files to render when using Asciidoctor.js + kroki in VS Code. So for now, I configured the VS Code plugin to use the Asciidoctor Ruby gems instead, as asciidoctor -r asciidoctor-diagram .

danyill commented 4 years ago

FWIW include support in asciidoctor-kroki is quite close: https://github.com/Mogztter/asciidoctor-kroki/pull/75

On Tue, May 26, 2020 at 12:41 AM tjallingran notifications@github.com wrote:

kroki https://kroki.io/ (GitHub https://github.com/yuzutech/kroki) has support for rendering PlantUML. The VS Code Asciidoctor https://github.com/asciidoctor/asciidoctor-vscode plugin uses that in combination with Asciidoctor.js, afaik.

Maybe that could work for atom-asciidoc as well.

That said, I write plantuml in separate files that I !include in my Asciidoc files, and I haven't managed to get the !included PlantUML files to render when using Asciidoctor.js + kroki in VS Code. So for now, I configured the VS Code plugin to use the Asciidoctor Ruby gems instead, as asciidoctor -r asciidoctor-diagram .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/asciidoctor/atom-asciidoc-preview/issues/122#issuecomment-633553172, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFEXXZWJB36PBO7VMEHDB3RTJRQRANCNFSM4B3JUBKA .

--

-- Private or confidential message? Public Key available here https://pgp.mit.edu/pks/lookup?search=dan.mulholland%40gmail.com&op=index :